Add valueOr to Validated, analog to Xor.valueOr #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkotsbak
force-pushed
the
Validated_valueOr
branch
from
26a044b
to
5765281
Compare
mkotsbak
force-pushed
the
Validated_valueOr
branch
from
5765281
to
ef69db1
Compare
Current coverage is 88.65%@@ master #1121 diff @@
==========================================
Files 227 227
Lines 2953 2954 +1
Methods 2897 2901 +4
Messages 0 0
Branches 53 50 -3
==========================================
+ Hits 2618 2619 +1
Misses 335 335
Partials 0 0
|
|
Looks great, thanks! Could we get a test for |
|
👍 |
1 similar comment
|
👍 |
|
I take it back -- the method is trivial enough that (for now) I'm not worried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.