Provide concise .toString for free structures. #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously calling .toString on a Free value would traverse the entire ADT of case classes. In some cases this would actually cause a stack overflow in the printing code. It also represented a (small) law violation (you could use the output to distinguish x and x.map(identity) in some cases). This change replaces the output with opaque "Free(...)" and "FreeApplicative(...)" strings.
Current coverage is 88.12%@@ master #1084 diff @@
==========================================
Files 224 224
Lines 2842 2844 +2
Methods 2785 2787 +2
Messages 0 0
Branches 52 52
==========================================
+ Hits 2505 2506 +1
- Misses 337 338 +1
Partials 0 0
|
|
👍 |
1 similar comment
|
👍 |
|
@non would you be willing to add a regression test that a deeply-nested |
|
@ceedubs added. |
|
Thanks @non! 👍 as soon as the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously calling .toString on a Free value would traverse
the entire ADT of case classes. In some cases this would
actually cause a stack overflow in the printing code. It
also represented a (small) law violation (you could use the
output to distinguish x and x.map(identity) in some cases).
This change replaces the output with opaque "Free(...)"
and "FreeApplicative(...)" strings.