Add partialComparison syntax (#3415)

typelevel · May 12, 2020 · 784a358 · 784a358
1 parent 36febec
commit 784a358
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/core/src/main/scala/cats/syntax/partialOrder.scala b/core/src/main/scala/cats/syntax/partialOrder.scala
@@ -13,6 +13,7 @@ final class PartialOrderOps[A](lhs: A)(implicit A: PartialOrder[A]) {
   def <=(rhs: A): Boolean = A.lteqv(lhs, rhs)
 
   def partialCompare(rhs: A): Double = A.partialCompare(lhs, rhs)
+  def partialComparison(rhs: A): Option[Comparison] = A.partialComparison(lhs, rhs)
   def tryCompare(rhs: A): Option[Int] = A.tryCompare(lhs, rhs)
   def pmin(rhs: A): Option[A] = A.pmin(lhs, rhs)
   def pmax(rhs: A): Option[A] = A.pmax(lhs, rhs)

diff --git a/tests/src/test/scala/cats/tests/PartialOrderSuite.scala b/tests/src/test/scala/cats/tests/PartialOrderSuite.scala
@@ -49,9 +49,10 @@ class PartialOrderSuite extends CatsSuite {
       (i <= j) should ===(PartialOrder.lteqv(i, j))
 
       checkPartialCompare(i.partialCompare(j), PartialOrder.partialCompare(i, j))
-      (i.tryCompare(j)) should ===(PartialOrder.tryCompare(i, j))
-      (i.pmin(j)) should ===(PartialOrder.pmin(i, j))
-      (i.pmax(j)) should ===(PartialOrder.pmax(i, j))
+      i.partialComparison(j) should ===(PartialOrder[POrd].partialComparison(i, j))
+      i.tryCompare(j) should ===(PartialOrder.tryCompare(i, j))
+      i.pmin(j) should ===(PartialOrder.pmin(i, j))
+      i.pmax(j) should ===(PartialOrder.pmax(i, j))
     }
   }
 }