Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default scheduler remove cancelled tasks. #568

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

avakhrenev
Copy link

Should prevent leaking timeouts.

@mpilquist mpilquist self-requested a review June 18, 2019 15:29
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method is only on ScheduledThreadPoolExecutor and you'll need a pattern match for it to compile. 👍 to the concept.

@avakhrenev
Copy link
Author

@rossabaker right, thank you.

@codecov-io
Copy link

Codecov Report

Merging #568 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage    88.8%   88.75%   -0.05%     
==========================================
  Files          77       77              
  Lines        2143     2143              
  Branches      129      126       -3     
==========================================
- Hits         1903     1902       -1     
- Misses        240      241       +1

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossabaker rossabaker merged commit 7c491c0 into typelevel:master Jun 19, 2019
@avakhrenev avakhrenev deleted the scheduler-remove-on-cancel branch July 4, 2019 09:08
Jacoby6000 added a commit to Jacoby6000/cats-effect that referenced this pull request Jul 26, 2019
djspiewak added a commit that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants