-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default scheduler remove cancelled tasks. #568
Make default scheduler remove cancelled tasks. #568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this method is only on ScheduledThreadPoolExecutor
and you'll need a pattern match for it to compile. 👍 to the concept.
@rossabaker right, thank you. |
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
- Coverage 88.8% 88.75% -0.05%
==========================================
Files 77 77
Lines 2143 2143
Branches 129 126 -3
==========================================
- Hits 1903 1902 -1
- Misses 240 241 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should prevent leaking timeouts.