Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Eq[IO[Either[F[A], A]]] from EffectTests #513

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

rossabaker
Copy link
Member

As long as we're breaking binary compatibility in laws, we can eliminate two warnings with this.

@rossabaker
Copy link
Member Author

Build is failing on JDK 11 install.

@djspiewak
Copy link
Member

Merge with master?

@rossabaker rossabaker force-pushed the remove-EqIOEitherFAA branch from 8622a84 to 0a582f3 Compare April 30, 2019 02:54
@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #513 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   89.61%   89.66%   +0.04%     
==========================================
  Files          71       71              
  Lines        2051     2051              
  Branches      140      140              
==========================================
+ Hits         1838     1839       +1     
+ Misses        213      212       -1

@rossabaker
Copy link
Member Author

I don't know whether our policy is to force-push or merge. Sorry to the half of you I enraged.

This pulls in #518 and should green it up.

@djspiewak
Copy link
Member

😡

@djspiewak djspiewak merged commit 0a582f3 into typelevel:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants