Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource.fromDestroyable #511

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

nigredo-tori
Copy link

This works exactly like Resource.fromAutoClosable, but for another standard interface. I had to add a ResourcePlatform, since this interface is not present in JS.

@alexandru
Copy link
Member

How many such interfaces does Java have? 😑

I'm 👍 on adding this, but please check Travis because the tests on OpenJDK 11 are failing.

Do we have problems on Java 11?

@nigredo-tori
Copy link
Author

nigredo-tori commented Apr 19, 2019

I'm +1 on adding this, but please check Travis because the tests on OpenJDK 11 are failing.
Do we have problems on Java 11?

The failure is not related to this PR:

Couldn't determine a download url for 11-GPL on linux-x64
The command "~/bin/install-jdk.sh --target "/home/travis/openjdk11" --workspace "/home/travis/.cache/install-jdk" --feature "11" --license "GPL" --cacerts" failed and exited with 1 during .

The PR itself shouldn't have problems with Java 11, since javax.security.auth.Destroyable is in java.base module.

UPD: https://travis-ci.community/t/install-of-openjdk11-is-failing-again/3061

@nigredo-tori nigredo-tori force-pushed the resource-from-destroyable branch from 686da53 to 90741b4 Compare April 19, 2019 13:08
@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #511 into master will increase coverage by 0.34%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage    89.6%   89.95%   +0.34%     
==========================================
  Files          70       71       +1     
  Lines        2050     2051       +1     
  Branches      196      210      +14     
==========================================
+ Hits         1837     1845       +8     
+ Misses        213      206       -7

@nigredo-tori
Copy link
Author

The Travis issue has been fixed, all the tests are green.

@djspiewak djspiewak merged commit 90741b4 into typelevel:master Apr 30, 2019
@nigredo-tori nigredo-tori deleted the resource-from-destroyable branch April 30, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants