Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.0-RC1 support #508

Merged
merged 4 commits into from
Apr 30, 2019
Merged

Scala 2.13.0-RC1 support #508

merged 4 commits into from
Apr 30, 2019

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 11, 2019

Fixes #507. Blocked by typelevel/cats#2783.

@rossabaker rossabaker changed the title Scala 2.13.0-RC1 support, sans cats WIP: Scala 2.13.0-RC1 support, sans cats Apr 11, 2019
@rossabaker rossabaker changed the title WIP: Scala 2.13.0-RC1 support, sans cats Scala 2.13.0-RC1 support Apr 26, 2019
Copy link
Member Author

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is built on binary-incompatible cats-laws, and should be released as 2.0.0-M1 for the same reason.

* limitations under the License.
*/

package cats.effect.internals
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that this is the best place for this. It replaces catalysts, and is only needed in tests.

@djspiewak
Copy link
Member

The interesting thing here is this implies that cats-effect 2.0 is going to have roughly the same hierarchy and features as cats-effect 1.0, and so any major changes get pushed to 3.0. It's just a naming thing, but it's worth calling out.

@rossabaker
Copy link
Member Author

Correct. It was an open question whether we'd break cats-effect-core in 2.0 with anything that's ready, or strictly follow cats' lead. My default stance is conservative here.

My stronger opinion is that a cats-effect-2.0 is needed quickly, compatible with cats-laws 2.0, and to deal with the eviction warnings that are about to plague us all.

@codecov-io
Copy link

codecov-io commented Apr 27, 2019

Codecov Report

Merging #508 into master will decrease coverage by 4.24%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #508      +/-   ##
=========================================
- Coverage   89.95%   85.7%   -4.25%     
=========================================
  Files          70      70              
  Lines        2050    2148      +98     
  Branches      128     131       +3     
=========================================
- Hits         1844    1841       -3     
- Misses        206     307     +101

@rossabaker
Copy link
Member Author

Build is now failing because the Java 11 install is repeatedly erring out on Travis CI.

@djspiewak
Copy link
Member

Merged your xenial PR. I think that unblocks this?

@rossabaker
Copy link
Member Author

Naughtily did a force push, since nobody had commented individual lines. I expect this build to be green.

@djspiewak djspiewak merged commit b8cc169 into typelevel:master Apr 30, 2019
@rossabaker rossabaker deleted the 2.13.0-RC1 branch April 30, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish for Scala 2.13.0-RC1, please
4 participants