Use ContextShift.apply in the tutorial #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 70 70
Lines 2043 2043
Branches 213 213
=======================================
Hits 1835 1835
Misses 208 208 |
Daenyth
approved these changes
Feb 25, 2019
ChristopherDavenport
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm new to Cats Effect, and tried the tutorial. This document is great, but I was a bit confused why the conventional
apply[F[_]]isn't used to obtain implicitContextShift[F]in the codes. I found that there wasn't theapply[F[_]]method forContextShiftat version 1.0.0, but we have it now (v1.2.0). It would be more readable if we useapply[F[_]]to obtain implicit value!