Document usage of -Wnonunit-statement
#4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure seems unrelated |
durban
reviewed
Apr 20, 2024
Co-authored-by: Daniel Urban <urban.dani@gmail.com>
|
Thanks for the review, I pushed changes :) |
|
@durban is there anything else to be done here from my side? Just to make sure I don't forget that I opened this ;) |
|
@froth Not at all. We're just slow ;-) In fact, this seems like a simple case, so I'll merge this PR this weekend, unless another maintainer objects (or merges it first). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3646
I will open another pull request against the g8 template adding the warning.