Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix issue #3979 #3983

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Try to fix issue #3979 #3983

merged 2 commits into from
Feb 1, 2024

Conversation

durban
Copy link
Contributor

@durban durban commented Jan 30, 2024

It's probably just CI being slow.

@durban durban linked an issue Jan 30, 2024 that may be closed by this pull request
Flakiness in SupervisorSpec #3979
Closed
@durban
Copy link
Contributor Author

durban commented Jan 31, 2024

Got a DispatcherSpec failure: https://github.com/typelevel/cats-effect/actions/runs/7718955085/job/21054837012?pr=3983#step:24:4777 🤷‍♂️

@durban
Copy link
Contributor Author

durban commented Jan 31, 2024 •
edited
Loading

SupervisorSpec failure, but a different one: https://github.com/typelevel/cats-effect/actions/runs/7718955085/job/21064623813?pr=3983#step:24:3300 😕

@durban
Copy link
Contributor Author

durban commented Feb 1, 2024

I've re-ran CI on this a lot of times, and the only failures remaining were in DispatcherSpec (which I expect will be fixed by #3923?), so this should be "fine".

@djspiewak djspiewak merged commit 083a31b into typelevel:series/3.5.x Feb 1, 2024
28 of 32 checks passed
@durban durban mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
🎨 backstage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flakiness in SupervisorSpec
2 participants
@durban @djspiewak