Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded notifyParked when worker transitions to blocking #3937

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Remove unneeded notifyParked when worker transitions to blocking #3937

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8341a4e
Remove unneeded `notifyParked` when worker transitions to blocking
armanbilge Jan 8, 2024
05145d9
`random` is no longer used
armanbilge Jan 8, 2024
c884c71
Merge branch 'series/3.5.x' into topic/worker-thread-cries-wolf
armanbilge Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,6 @@ private final class WorkerThread(
* code path can be exercised is through `IO.delay`, which already handles exceptions.
*/
override def blockOn[T](thunk: => T)(implicit permission: CanAwait): T = {
val rnd = random

pool.notifyParked(rnd)

if (blocking) {
// This `WorkerThread` is already inside an enclosing blocking region.
// There is no need to spawn another `WorkerThread`. Instead, directly
Expand Down
Loading