-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cats.mtl.Local[IO, E]
from IOLocal[E]
#3429
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f33c083
cats.mtl.Local[IO, E] from IOLocal[E]
rossabaker 0fb5754
Move IOLocal.local to IO.local
rossabaker efc096d
Scala 3 wants explicitly typed implicits
rossabaker e7ebf43
Merge branch 'series/3.x' into mtl
armanbilge 79180ac
Scalafix
armanbilge 1d42c9c
You forgot a percentage sign
armanbilge 36d5b17
`toLocal` -> `asLocal`
armanbilge 94e126e
%%%%%%%%%%%%%%%%%%%
armanbilge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
tests/shared/src/test/scala/cats/effect/IOMtlLocalSpec.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright 2020-2022 Typelevel | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package cats | ||
package effect | ||
|
||
import cats.mtl.Local | ||
import cats.mtl.laws.discipline._ | ||
|
||
import org.typelevel.discipline.specs2.mutable.Discipline | ||
|
||
import java.util.concurrent.CancellationException | ||
|
||
class IOMtlLocalSpec extends BaseSpec with Discipline { | ||
sequential | ||
|
||
implicit val ticker: Ticker = Ticker() | ||
|
||
implicit val local: Local[IO, Int] = | ||
// Don't try this at home | ||
unsafeRun(IO.local(0)).fold( | ||
throw new CancellationException("canceled"), | ||
throw _, | ||
_.get | ||
) | ||
|
||
checkAll("Local[IO, Int]", LocalTests[IO, Int].local[Int, Int]) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could conceivably be made a method on
IOLocal
itself as well, with this becoming a simple delegate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like thin instances, but if we're discouraging non-Local use of
IOLocal
, maybe we shouldn't make it easier to use.