Introduce raceOutcomeBoth
#3232
Conversation
|
Crap, this was a false generalization.
I've currently implemented I have to think about this. |
| /** | ||
| * Races the evaluation of two fibers, cancels the loser, and returns the [[Outcome]] of both. | ||
| * If the race is canceled before one or both participants complete, then then whichever ones | ||
| * are incomplete are canceled. |
There was a problem hiding this comment.
I may be misunderstanding the intention, but this doesn't seem to be true: if one is canceled, and then the race is canceled while trying the join the other, then the other will not be canceled.
There was a problem hiding this comment.
Ah, thanks. I think the scaladoc was expressing my intent, I just screwed up the implementation 😅
| case Left((oca, f)) => | ||
| val joined = | ||
| if (oca.isCanceled) | ||
| poll(f.join) |
There was a problem hiding this comment.
See above, if we're canceled here, f will not be canceled.
There was a problem hiding this comment.
You're right, I think this needs an .onCancel(f.cancel). And same below.
| case Right((f, ocb)) => | ||
| val joined = | ||
| if (ocb.isCanceled) | ||
| poll(f.join) |
This allows us to generalize over
raceOutcomeandrace. The motivation for this is to be able to handle the race condition where both fibers succeed, even though the loser is canceled. More on that in a follow-up PR.If this merges then I think I need to re-do #3226 in terms of
raceOutcomeBothinstead.