Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed console example #2834

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

ivanagustinmonzon
Copy link
Contributor

Added Monad constraint and removed extra implicit

armanbilge
armanbilge previously approved these changes Feb 20, 2022
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM! Much appreciated :)

Ideally we'd set up something like sbt-doctest to avoid this in the future :)

Co-authored-by: Arman Bilge <armanbilge@gmail.com>
* import cats.syntax.all._
* import cats.Monad
* import cats.effect.std.Console
* import cats.syntax.all._

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: why the leading space?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess scalafmt did something odd. It seems to really struggle with code snippets in scaladoc.

@djspiewak djspiewak merged commit f423ac7 into typelevel:series/3.x Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants