Simplify the transfer of WorkerThread data structures when blocking #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no performance regressions.
Benchmark (size) Mode Cnt Score Error Units
BlockingBenchmark.blockThenCede 10000 thrpt 20 6.585 ± 0.231 ops/s
BlockingBenchmark.coarse 10000 thrpt 20 3456.943 ± 105.862 ops/s
BlockingBenchmark.fine 10000 thrpt 20 760.317 ± 10.131 ops/s
BlockingBenchmark.nested 10000 thrpt 20 749.588 ± 10.078 ops/s
Benchmark (size) Mode Cnt Score Error Units
BlockingBenchmark.blockThenCede 10000 thrpt 20 6.626 ± 0.269 ops/s
BlockingBenchmark.coarse 10000 thrpt 20 3507.987 ± 136.174 ops/s
BlockingBenchmark.fine 10000 thrpt 20 756.288 ± 12.685 ops/s
BlockingBenchmark.nested 10000 thrpt 20 745.676 ± 15.207 ops/s |
armanbilge
reviewed
Jan 22, 2022
Comment on lines
+456
to
+457
| if (isDotty.value) { | ||
| // Scala 3 specific exclusions |
There was a problem hiding this comment.
Hopefully these are only temporary.
djspiewak
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the code by moving the references to the data structures inside the pool itself, where the WorkerThreads can fetch it from as soon as they are assigned an index. I have plans to further simplify the code, I would like to get rid of the
ArrayBlockingQueue[Integer](Integerneeded becausenullis a part of the API and we don't want autoboxing to be coerced to a 0 by Scala), but there are enough changes in this PR.This will also be a nice cleanup when I introduce the
sleepimprovements.