Only use FiberAwareExecutionContext if tracing is enabled
#2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for being picky, but for anyone reading this, this PR does not actually improve performance, it just makes sure that when tracing is disabled, there are no debugging features enabled in the runtime, in this case, tracking fibers for generating fiber dumps. |
vasilmkd
approved these changes
Dec 10, 2021
|
Thanks for the clarification 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the JS performance regression reported by @rpiaggio in #2634 (comment). Credit to @vasilmkd for identifying the problem.