Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher "raise an error on leaked runner" flake #3776

Closed
armanbilge opened this issue Aug 6, 2023 · 3 comments
Closed

Dispatcher "raise an error on leaked runner" flake #3776

armanbilge opened this issue Aug 6, 2023 · 3 comments
Assignees
Labels

Comments

@armanbilge
Copy link
Member

5504419

https://cirrus-ci.com/task/5809014697623552?logs=main#L3024

[info] DispatcherSpec
[info] sequential dispatcher should
[info]   await = true
...
[error]     x raise an error on leaked runner
[error]      Expected: java.lang.IllegalStateException. Got nothing (DispatcherSpec.scala:256)

"raise an error on leaked runner" in real {
dispatcher.use(IO.pure(_)) flatMap { runner =>
IO {
runner.unsafeRunAndForget(IO(ko)) must throwAn[IllegalStateException]
}
}
}

@samspills samspills self-assigned this Aug 6, 2023
@armanbilge
Copy link
Member Author

armanbilge added a commit to armanbilge/cats-effect that referenced this issue Sep 23, 2023
@armanbilge
Copy link
Member Author

By adding replicates to the test in efd0c23 I was able to reproduce more easily. It's not specific to any Dispatcher, just seems generally broken 😕

sbt:cats-effect> testsJVM/testOnly cats.effect.std.DispatcherSpec -- ex "raise an error on leaked runner"
[info] DispatcherSpec
[info] sequential dispatcher should
[info]   await = true
[error]     x raise an error on leaked runner
[error]      Expected: java.lang.IllegalStateException. Got nothing (DispatcherSpec.scala:256)
[info]   await = false
[error]     x raise an error on leaked runner
[error]      Expected: java.lang.IllegalStateException. Got nothing (DispatcherSpec.scala:256)
[info] parallel dispatcher should
[info]   await = true
[error]     x raise an error on leaked runner
[error]      Expected: java.lang.IllegalStateException. Got nothing (DispatcherSpec.scala:256)
[info]   await = false
[error]     x raise an error on leaked runner
[error]      Expected: java.lang.IllegalStateException. Got nothing (DispatcherSpec.scala:256)
[info] Total for specification DispatcherSpec

@armanbilge armanbilge changed the title Sequential Dispatcher "raise an error on leaked runner" flake Dispatcher "raise an error on leaked runner" flake Sep 23, 2023
@durban
Copy link
Contributor

durban commented Oct 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants