Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to Github Actions #288

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Migrate CI to Github Actions #288

merged 1 commit into from
Dec 14, 2020

Conversation

felixbr
Copy link
Contributor

@felixbr felixbr commented Dec 14, 2020

This is a first attempt. I copied most of it from typelevel/cats.

@felixbr felixbr marked this pull request as ready for review December 14, 2020 19:29
@travisbrown
Copy link
Contributor

Have you looked at sbt-github-actions? I used it recently for Dhall for Java and @jatcwang used it for several Circe projects and it seems pretty convenient.

@travisbrown
Copy link
Contributor

(I'd also be happy to have us merge this as-is.)

@felixbr
Copy link
Contributor Author

felixbr commented Dec 14, 2020

I actually looked at sbt-github-actions first but since cats, doobie and other projects seemed to not use it, I just followed their example. I didn't realize that the plugin is used to generate the yaml files but it makes sense in retrospect.

I'll clean up the PR and we can merge this and I'll take a look at the sbt-plugin again and possibly open another one. For now I just wanted to make sure to migrate before we run into trouble with travis-ci (I couldn't find a clear deadline, so I'd assume rather sooner than later). Right now it aims to be a 1-to-1 migration of the travis-ci build (minus sbt-travisci).

I'm not too familiar with codecov but I assume the bot will only post in the PR if something has changed in the code.

@felixbr felixbr force-pushed the topic/github-actions branch from 60b0f6c to 26acf89 Compare December 14, 2020 20:04
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #288 (26acf89) into master (f5f05e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files           9        9           
  Lines         162      162           
  Branches        3        3           
=======================================
  Hits          148      148           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f05e9...26acf89. Read the comment docs.

@felixbr felixbr merged commit e4c4d1d into master Dec 14, 2020
@felixbr felixbr deleted the topic/github-actions branch December 14, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants