Introduce ContextShift for Rerunnable #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to issue #157.
Neither
Future
norIO
provide a way to get a handle on the underlying thread-pool, so the only way to construct aContextShift
instance is to pass a handle to anExecutionContext
explicitly.@ben-healthforge mentioned in the issue that this "seems wrong", but I currently don't see a way around it. Feel free to comment if you have any ideas :)
monix.eval.Task
is worth mentioning which providesTask.deferAction { implicit scheduler => ... }
to get a handle on the underlyingScheduler
and I've read this will probably make it intocats-effect
3.0.For the moment I'd go with this implementation, which is closer to the one for
IO
.In the tests I've tried to check correct context-switching for common scenarios like calling into a library like
fs2
orhttp4s
from a Finagle/Finatra application (which is based onFuture
). Hope this makes sense.