This repository has been archived by the owner on Mar 25, 2020. It is now read-only.
Update to Scala 2.12.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.95% (diff: 100%)@@ master #8 diff @@
==========================================
Files 35 35
Lines 458 458
Methods 403 403
Messages 0 0
Branches 55 55
==========================================
Hits 412 412
Misses 46 46
Partials 0 0
|
travisbrown
force-pushed
the
update/scala-2.12.0
branch
from
664c78b
to
600f738
Compare
|
👍 |
|
LGTM 👍 |
|
released as 1.3.2 (there was glitch with 1.3.1 release) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, the Scoverage compiler plugin, runtime, and SBT plugin are all updated. The SBT plugin hasn't been synced to Maven Central yet (even though it was published yesterday), but adding the Sonatype releases resolver makes this work until it gets synced. Given that this is all build stuff, I don't think that's unreasonable.
There is still
twoone thing that seems to be broken in Scoverage: in sbt-scoverage 1.5.0, the default Scoverage compiler plugin version is wrong (it's the 1.3.0 snapshot, not release). This is easy enough to work around with a bit of explicit configuration.The bigger problem is that the Scoverage runtime isn't published for Scala.js on Scala 2.11 (on either Maven Central or Sonatype releases). As soon as that's done this PR should be ready for review.We're still waiting on Scoverage, but these changes at least allow us to publish Catalysts locally and test the Cats 2.12.0 build (just not with Scoverage).