Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache dynamically created manager nodes #840

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Cache dynamically created manager nodes #840

merged 1 commit into from
Mar 31, 2022

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Jan 31, 2022

  • Non plugin generated, "cross_ref"s points to dynamically
    created managers (e.g. Model.objects) and can make Mypy fail on
    cached runs

Related issues

Fixes: #839

@flaeppe
Cache dynamically created manager nodes
cafbe07 
- Non plugin generated, "cross_ref"s points to dynamically
  created managers (e.g. `Model.objects`) and can make Mypy fail on
  cached runs
@flaeppe
Copy link
Member Author

flaeppe commented Mar 30, 2022

@sobolevn do you think this is a reasonable change? Since "cross_ref" can point to a type that won't exist in the mypy cache.

sobolevn
sobolevn approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it! Thank you!

@sobolevn sobolevn merged commit 92e5f20 into typeddjango:master Mar 31, 2022
@flaeppe flaeppe deleted the fix/no-serialize-breaks-cache branch March 31, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lookup of dynamically created managers crashes on cached runs
2 participants
@flaeppe @sobolevn