Fix types for TestCase.assertJSON{Not,}Equal
#2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of this function just passes the `raw` value to `json.loads`, which [is typed as accepting][1] strings, bytes objects, or bytearrays. Update the signature of `assertJSONEqual` and `assertJSONNotEqual` to match. [1]: https://github.com/python/typeshed/blob/aac4394eb29d86797628b57d6f01f5e17f5ff83f/stdlib/json/__init__.pyi#L40
nickstenning
force-pushed
the
fix-assert-json-equals-types
branch
from
f6f1ebc to
ff0600d
Compare
sobolevn
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of this function just passes the
rawvalue tojson.loads, which is typed as accepting strings, bytes objects, or bytearrays.Update the signature of
assertJSONEqualandassertJSONNotEqualto match.Please let me know if I missed important things from the contributor process?