Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples links #610

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

dmitrii-ubskii
Copy link
Member

@dmitrii-ubskii dmitrii-ubskii commented Jul 27, 2022

What is the goal of this PR?

We update all links to the examples now that typedb-examples was restructured.

What are the changes implemented in this PR?

Merge after https://github.com/vaticle/typedb-examples/pull/137 is merged. Closes https://github.com/vaticle/typedb-examples/issues/122.

@dmitrii-ubskii dmitrii-ubskii changed the title Example domains Update examples links Jul 27, 2022
@grabl grabl requested a review from alexjpwalker July 27, 2022 13:45
@dmitrii-ubskii dmitrii-ubskii marked this pull request as ready for review July 27, 2022 13:46
@dmitrii-ubskii dmitrii-ubskii merged commit fea21b9 into typedb:master Jul 28, 2022
This was referenced Aug 5, 2022
jamesreprise added a commit to jamesreprise/vaticle-docs that referenced this pull request Aug 5, 2022
## What is the goal of this PR?

We fix a typo in the link that was overlooked in typedb#610

## What are the changes implemented in this PR?

The typo is fixed, the link points to the correct destination. Furthermore, we have opened an issue to look at preventing this class of errors in the future: typedb#612.
@jamesreprise jamesreprise mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs should include links to all examples
3 participants