Move ember-template-imports to dependencies instead of peerDependencies #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es so that consumers can have a better experience out of the box
wagenet
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
#655
is being worked on, we need an interim solution for Glint.
Today, (for apps, addons, and v2 addons) it's broken out of the box for gts, because when folks install ember-template-imports, they get v4, which removed all the APIs Glint was using.
By moving ember-template-imports in Glint to be a dependency, Glint keeps those APIs, and is no longer broken-by-default.
This should be a patch-release, imo.