Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use devDependencies for in-repo dummy addons. #252

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

dfreeman
Copy link
Member

@dfreeman dfreeman commented Sep 5, 2018

This was raised in Discord — the new PackageInfoCache stuff in ember-cli@3.4 complains loudly about missing packages in our published paths entry.

WARNING:
WARNING: /Users/jasonevans/projects/open-x/node_modules/ember-cli-typescript/tests/dummy/lib/in-repo-a:
WARNING:    Missing package directory
WARNING:
WARNING: /Users/jasonevans/projects/open-x/node_modules/ember-cli-typescript/tests/dummy/lib/in-repo-b:
WARNING:    Missing package directory
WARNING:
WARNING: /Users/jasonevans/projects/open-x/node_modules/ember-cli-typescript/tests/dummy/lib/in-repo-c:
WARNING:    Missing package directory
WARNING:
WARNING: /Users/jasonevans/projects/open-x/node_modules/simple-html-tokenizer/commands:
WARNING:    Missing package directory
WARNING: For addon at path /Users/jasonevans/projects/open-x/node_modules/ember-cli-typescript:
WARNING:    Excluding invalid/malformed/missing addon at relative path 'tests/dummy/lib/in-repo-a'
WARNING:    Excluding invalid/malformed/missing addon at relative path 'tests/dummy/lib/in-repo-b'
WARNING:    Excluding invalid/malformed/missing addon at relative path 'tests/dummy/lib/in-repo-c'

Making them link: devDependencies instead should eliminate any references for downstream consumers.

The new PackageInfoCache stuff in ember-cli@3.4 complains loudly
about missing packages in our published `paths` entry.
@jasonmevans
Copy link

Thanks for jumping on that, guys!

@jamescdavis
Copy link
Member

For reference: yarnpkg/yarn#3359

@dfreeman
Copy link
Member Author

dfreeman commented Sep 5, 2018

Thanks @jamescdavis. You and @dwickern good with this change?

Copy link
Contributor

@dwickern dwickern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-north
Copy link
Contributor

mike-north commented Sep 5, 2018

Can we consult someone on the ember-cli team before merging this? We would be diverging from the way in-repo addons and engine codegen stuff is set up. My bad. Just realized that this is 100% in the stuff we use for tests, and not in anything that would be generated on the consumer side.

👍

@dfreeman
Copy link
Member Author

dfreeman commented Sep 5, 2018

It was also @rwjblue's suggestion in the first place 😉

@dfreeman dfreeman merged commit a969f2b into master Sep 5, 2018
@dfreeman dfreeman deleted the dev-deps-for-in-repo-dummy-addons branch September 5, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants