Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cleaning while no mop attached #2

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

FrancYescO
Copy link

@FrancYescO FrancYescO commented Apr 16, 2021

@tykarol tykarol merged commit 536565d into tykarol:master May 10, 2021
@FrancYescO
Copy link
Author

This does not look as merged, still have the issue after the update to 1.2.3

@tykarol
Copy link
Owner

tykarol commented May 17, 2021

@FrancYescO
Copy link
Author

if you have the 2in1 box and no mop attached it will keep setting the vacuum in mopping mode causing the "cannot clean as no mop attached" error

@tykarol
Copy link
Owner

tykarol commented May 17, 2021

I checked and I get the same voice message from the vacuum. Do you verify your PR changes before submitting it and it works?

@FrancYescO
Copy link
Author

FrancYescO commented May 17, 2021

yep as actually to get it (re)fixed i've just c&p the full raw file from my fork https://github.com/FrancYescO/home-assistant-viomi-vacuum-v8/blob/4e6bbd7fa95f2a720b7816c589c023842b9887b0/custom_components/viomi_vacuum_v8/vacuum.py

sincerely idk what's still wrong when downloaded from HACS, as the repo files looks the same

@tykarol
Copy link
Owner

tykarol commented May 17, 2021

Ok, the 1.2.3 version is before the full PR merge, I released the 1.2.4 version with the last changes from the master.

@tykarol
Copy link
Owner

tykarol commented May 17, 2021

I can confirm that now works correctly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants