Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions Pipeline - run unit tests as PR validation and on demand #7

Closed
3 tasks done
Tracked by #1
razvangoga opened this issue Feb 13, 2024 · 4 comments · Fixed by #20
Closed
3 tasks done
Tracked by #1

Github Actions Pipeline - run unit tests as PR validation and on demand #7

razvangoga opened this issue Feb 13, 2024 · 4 comments · Fixed by #20
Assignees
Labels
cicd enhancement New feature or request
Milestone

Comments

@razvangoga
Copy link
Collaborator

razvangoga commented Feb 13, 2024

  • new github actions pipeline for continuous integration
  • runs on demand
  • runs as a mandatory check for all PRs
@razvangoga razvangoga changed the title CI Github Actions Pipeline - run unit tests as PR validation and on demand Feb 13, 2024
@razvangoga razvangoga added this to the Working Tye2 milestone Feb 13, 2024
@razvangoga razvangoga mentioned this issue Feb 19, 2024
2 tasks
@razvangoga razvangoga self-assigned this Feb 19, 2024
@razvangoga razvangoga added the enhancement New feature or request label Feb 27, 2024
@razvangoga
Copy link
Collaborator Author

general notes

on linux agent

  • almost all tests are green : 203 / 209
image image

on windows agent

  • the windows agents are only partially usable because they seem to use the Windows Container version of Docker Desktop => any linux only container image (ex Redis for Dapr) is not usable on it

macos agents

  • the run minute for a macos agent is 10x as expensive as a linux one 👎
  • does not come with Docker Desktop installed and the installation takes a lot of time

@razvangoga
Copy link
Collaborator Author

When running as PR check the test results are published in the PR thread
image

@drakon660
Copy link
Contributor

Great Job!

Regarding agents, what do you think would be future approach, because we need a pipeline to release Tye2 especially on Windows
and also macOS?

@razvangoga
Copy link
Collaborator Author

for the release i think all agents should work - most of my problems with the windows and macos have to do with the docker instance on them (or lack thereof).

for pack and push we only need the source code and the dotnet sdk

razvangoga added a commit that referenced this issue Feb 29, 2024
* #7 moved all MS build scripts out of the way. all projects are building

* added ci pipeline draft definition

* fixed proxy prj not building

* added test step

* dotnet build & dotnet test are running

* dotnet build and dotnet test are working

* dotnet test no longer crashes

* added test results publish

* added Azure Functions and Dapr SDKs

* added dapr init to pipeline

* fix for Configuration doesn't allow containers to access services on the host

* create network manualy

* os matrix

* xplat test runner fix

* Setup Docker on macOS

* win install tweaks

* back to powershell

* win uses powershell

* try to get win build running

* script tweak

* path fix

* switchwed to dapr install action

* leave dapr aside for now

* back to ubuntu

* removed matrix

* missing condition

* just the failing

* see docker host ip

* fix for ubuntu??

* check if linux in pipeline

* only tests that run in pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants