fix(primitives): Fix native scripts policy id (add missing tag) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmaugPool
commented
Apr 26, 2022
pallas-crypto/src/hash/hasher.rs
Outdated
| #[inline] | ||
| pub fn hash_tagged_cbor( | ||
| data: &impl minicbor::Encode, | ||
| tag: &[u8], |
There was a problem hiding this comment.
We could also use a single u8 if preferred as this will likely cover all use cases for a long time.
There was a problem hiding this comment.
I changed it to an u8 in updated version.
SmaugPool
force-pushed
the
fix-native-scripts-policy-id
branch
from
dcd2c06
to
bd2044d
Compare
scarmuega
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native scripts hashes need the tag 0 to compute the correct policy id, see:
https://github.com/input-output-hk/cardano-ledger/blob/736c9295f5896de28fbcedc6a8fc4d509fb78d10/shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/Scripts.hs#L61-L65
https://github.com/input-output-hk/cardano-ledger/blob/736c9295f5896de28fbcedc6a8fc4d509fb78d10/shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/Scripts.hs#L163-L171
We can add a comment in the code if you want.