Changes to grafana page and add timeout to scraper #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the new dashboard. This shows the effect of an defective upstream amplifier being replaced at 10:48 AM.
|
twstokes
reviewed
Jan 28, 2022
Look at how pretty the Correcteds graph is! NFT material! 🤣 |
This makes sense! I've found mine just accumulate over time until a restart, so a flat graph (but a high number) isn't necessarily bad, it could show stability. What we really care about are fluctuations. 👍 This also makes setting up an alert a lot easier. 🔔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the grafana page to show the change in Corrected and Uncorrectables instead of the total numbers. The change is the non-negative difference between the most recent values. This is more useful because if an internet connection is unstable, users will want to see how the errors are fluctuating, not the total numbers.
Add a time out to requests.get() to prevent the scraper from hanging if the webpage is non-responsive.