Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small variants (1-2bp insertions and deletion) are not phased #8

Closed
vyx-lucy-kaplun opened this issue Mar 1, 2022 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@vyx-lucy-kaplun
Copy link

Longphase does not phase small variants (such as 1-2 base insertions and deletions) while it successfully phases SNPs.

chr22 10690636 . G T 20.70 PASS P GT:GQ:DP:AF:PS 0|1:20:60:0.5000:10690636
chr22 10690637 . C T 16.59 PASS F GT:GQ:DP:AF:PS 0|1:16:60:0.5167:10690636
chr22 10690675 . A G 8.84 PASS F GT:GQ:DP:AF:PS 0|1:8:60:0.4667:10690636
chr22 10690687 . A C 19.10 PASS P GT:GQ:DP:AF:PS 0|1:19:60:0.4667:10690636
chr22 10690767 . G T 15.98 PASS F GT:GQ:DP:AF:PS 0|1:15:61:0.4918:10690636
chr22 10690778 . T G 19.85 PASS F GT:GQ:DP:AF:PS 0|1:19:61:0.4426:10690636
chr22 10690871 . G A 12.05 PASS F GT:GQ:DP:AF:PS 0|1:12:60:0.3333:10690636
chr22 10690879 . C T 12.07 PASS F GT:GQ:DP:AF:PS 0|1:12:60:0.3000:10690636
chr22 10690945 . A AT 6.33 PASS F GT:GQ:DP:AF:PS 0/1:6:61:0.2787:.
chr22 10690998 . A T 13.83 PASS F GT:GQ:DP:AF:PS 0|1:13:62:0.4032:10690636
chr22 10691083 . C T 16.04 PASS F GT:GQ:DP:AF:PS 0|1:16:62:0.5323:10690636
chr22 10691118 . A G 20.58 PASS P GT:GQ:DP:AF:PS 0|1:20:62:0.4677:10690636
chr22 10691148 . G T 15.89 PASS F GT:GQ:DP:AF:PS 0|1:15:62:0.4839:10690636
chr22 10691160 . A G 7.66 PASS F GT:GQ:DP:AF:PS 0|1:7:62:0.4355:10690636
chr22 10691167 . CTT C 11.78 PASS F GT:GQ:DP:AF:PS 0/1:11:62:0.3065:.
chr22 10691190 . T C 16.34 PASS F GT:GQ:DP:AF:PS 0|1:16:62:0.5161:10690636
chr22 10691191 . A G 20.96 PASS P GT:GQ:DP:AF:PS 0|1:20:62:0.5323:10690636

I am using a small variants vcf file created by Clair3, a structural variants vcf created by Cute_SV, and the following phasing command:
longphase_linux-x64 phase  -s merge_output.vcf.gz --sv-file cutesv.vcf.gz  -b sorted.bam -r hg38.fa -t 8 -o longphase_combined.phased --ont

@ythuang0522
Copy link
Collaborator

We skipped phasing small indels due to lower accuracy compared with SNPs called by DeepVariant or Clair, especially in ONT with frequent indel errors. It can be implemented at the cost of increasing switch errors. Having said that, we will add this as an additional option, similar to whatshap, in the future.

@ythuang0522 ythuang0522 added the enhancement New feature or request label Mar 10, 2022
@mproberts99
Copy link

Is this feature still going to be added?

@ythuang0522
Copy link
Collaborator

ythuang0522 commented Jan 27, 2023

Hi, the co-phasing of small indels was postponed due to the concern of ONT indel errors which reduce phasing accuracy. Since then we put our efforts mostly on improving the SNP-only phasing accuracy. Having said that, we noticed the upcoming R10.4 seems getting rid of the homopolymer issue. Recently, we are sparing time for implementing the indel co-phasing, which would take a few weeks. So yes, it will be added in the next version.

twolinin added a commit that referenced this issue May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants