Avoid unnecessary requests by checking most recent url before proceeding #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, at first glance this seems like it should do the trick. Before I merge it in, let me think about this a little more to make sure it doesn't have any unintended side effects. Also, can you revert your changes to the dist/ files? I only generate those at release time. Thanks! |
|
I reverted dist. Yes thanks for looking it over. We don't want any nasty regressions. I should also note that I haven't tested this with a Typeahead, since I'm using bloodhound on its own. |
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #149
Everytime the transport is used to make a request, the url is stashed. When the rateLimited _get goes through, if the url that it is about to make a request for differs from the most recent url, then it aborts.
Tests are passing, but I'm not certain this maintains all desired functionality.