Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing wrapper to define $ as jQuery #47

Closed
wants to merge 1 commit into from
Closed

Missing wrapper to define $ as jQuery #47

wants to merge 1 commit into from

Conversation

daraosn
Copy link
Contributor

@daraosn daraosn commented Feb 25, 2013

  • Some sites use both Prototype and jQuery. This wrapper helps avoiding confusions when not using the $ variable as jQuery.

@jharding
Copy link
Contributor

The files in dist/ are generated from the files in src/. If you update your pull request to modify src/js/intro.js and src/js/outro.js it'll go out in v0.8.2.

@daraosn
Play nice with sites using $ with jQuery.noConflict()
885550d 
* i.e. Some sites use both Prototype and jQuery. This wrapper helps avoiding confusions when not using the $ variable as jQuery.
@daraosn
Copy link
Contributor Author

daraosn commented Feb 25, 2013

Sure, it should be good now.

@jharding
Copy link
Contributor

Merged into integration-0.8.2.

@jharding jharding closed this Feb 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@daraosn @jharding