Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide hint for long queries #26

Merged

Conversation

jharding
Copy link
Contributor

Fixes #16. 😎

@@ -126,6 +129,12 @@ var InputView = (function() {
return (this.$input.css('direction') || 'ltr').toLowerCase();
},

isOverflow: function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like this: this.$input[0].scrollWidth > this.$input.width()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think that'll work in Firefox. https://bugzilla.mozilla.org/show_bug.cgi?id=343143

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn.

@timtrueman
Copy link
Contributor

#ShipIt

jharding added a commit that referenced this pull request Feb 22, 2013
@jharding jharding merged commit dd61bdf into twitter:integration-0.8.1 Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants