attaching the respective dataset to rendered suggestions #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the pull request but this looks to be a duplicate of #207 which has already been merged into |
|
Awesome, thank you. I would suggest updating the README as well to reflect this change. |
|
Yep, I'll be sure to do that as soon as the changes are merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to know from which dataset the suggestion originated and currently there's no way to accomplish that. This pull request attempts to solve that problem by passing the relevant dataset as a second argument to the
typeahead:selectedandtypeahead:autocompletedevents