Merge pull request #112 from jharding/49-change-behavior-of-autocomplete

Change behavior of autocomplete
twitter · Mar 14, 2013 · 6fcd112 · 6fcd112
2 parents 7fd872d + 56354bb
commit 6fcd112
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/typeahead_view.js b/src/typeahead_view.js
@@ -239,7 +239,7 @@ var TypeaheadView = (function() {
     },
 
     _autocomplete: function(e) {
-      var isCursorAtEnd, ignoreEvent, query, hint;
+      var isCursorAtEnd, ignoreEvent, query, hint, suggestion;
 
       if (e.type === 'rightKeyed' || e.type === 'leftKeyed') {
         isCursorAtEnd = this.inputView.isCursorAtEnd();
@@ -253,7 +253,8 @@ var TypeaheadView = (function() {
       hint = this.inputView.getHintValue();
 
       if (hint !== '' && query !== hint) {
-        this.inputView.setInputValue(hint);
+        suggestion = this.dropdownView.getFirstSuggestion();
+        this.inputView.setInputValue(suggestion.value);
       }
     },
 

diff --git a/test/typeahead_view_spec.js b/test/typeahead_view_spec.js
@@ -361,6 +361,7 @@ describe('TypeaheadView', function() {
       beforeEach(function() {
         this.inputView.getQuery.andReturn('app');
         this.inputView.getHintValue.andReturn('apple');
+        this.dropdownView.getFirstSuggestion.andReturn({ value: 'apple' });
 
         this.inputView.trigger('tabKeyed', this.$e);
       });
@@ -379,6 +380,7 @@ describe('TypeaheadView', function() {
     beforeEach(function() {
       this.inputView.getQuery.andReturn('app');
       this.inputView.getHintValue.andReturn('apple');
+      this.dropdownView.getFirstSuggestion.andReturn({ value: 'apple' });
       this.inputView.isCursorAtEnd.andReturn(true);
       this.inputView.getLanguageDirection.andReturn('ltr');
     });
@@ -424,6 +426,7 @@ describe('TypeaheadView', function() {
     beforeEach(function() {
       this.inputView.getQuery.andReturn('app');
       this.inputView.getHintValue.andReturn('apple');
+      this.dropdownView.getFirstSuggestion.andReturn({ value: 'apple' });
       this.inputView.isCursorAtEnd.andReturn(true);
       this.inputView.getLanguageDirection.andReturn('ltr');
     });