Trigger typeahead:opened and typeahead:closed.

twitter · Mar 11, 2013 · 04d8f2a · 04d8f2a
1 parent daf000f
commit 04d8f2a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 2 deletions.
diff --git a/src/typeahead_view.js b/src/typeahead_view.js
@@ -80,7 +80,8 @@ var TypeaheadView = (function() {
     .on('cursorRemoved', this._updateHint)
     .on('suggestionsRendered', this._updateHint)
     .on('opened', this._updateHint)
-    .on('closed', this._clearHint);
+    .on('closed', this._clearHint)
+    .on('opened closed', this._propagateEvent);
 
     this.inputView = new InputView({ input: $input, hint: $hint })
     .on('focused', this._openDropdown)
@@ -261,6 +262,10 @@ var TypeaheadView = (function() {
       }
     },
 
+    _propagateEvent: function(e) {
+      this.eventBus.trigger(e.type);
+    },
+
     // public methods
     // --------------
 

diff --git a/test/playground.html b/test/playground.html
@@ -101,7 +101,11 @@
           "Wyoming"
         ]
       })
-      .on('typeahead:selected', logToTextarea);
+      .on([
+        'typeahead:selected',
+        'typeahead:opened',
+        'typeahead:closed'
+      ].join(' '), logToTextarea);
 
       $('.bad-tokens').typeahead({
         local: [
@@ -147,6 +151,7 @@
             stringifiedArgs = JSON ? JSON.stringify(args) : '';
 
         $textarea.val([val, type, stringifiedArgs, '\n'].join('\n'));
+        $textarea[0].scrollTop = $textarea[0].scrollHeight;
       }
     </script>
   </body>

diff --git a/test/typeahead_view_spec.js b/test/typeahead_view_spec.js
@@ -92,14 +92,32 @@ describe('TypeaheadView', function() {
     _updateHintSpecHelper('dropdownView', 'suggestionsRendered');
   });
 
+  describe('when dropdownView triggers opened', function() {
+    beforeEach(function() {
+      this.spy = spyOnEvent(this.$input, 'typeahead:opened');
+      this.dropdownView.trigger('opened');
+    });
+
+    // TODO: test _updateHint path
+
+    it('should trigger typeahead:opened on the input', function() {
+      expect(this.spy).toHaveBeenTriggered();
+    });
+  });
+
   describe('when dropdownView triggers closed', function() {
     beforeEach(function() {
+      this.spy = spyOnEvent(this.$input, 'typeahead:closed');
       this.dropdownView.trigger('closed');
     });
 
     it('should clear hint', function() {
       expect(this.inputView.setHintValue).toHaveBeenCalledWith('');
     });
+
+    it('should trigger typeahead:closed on the input', function() {
+      expect(this.spy).toHaveBeenTriggered();
+    });
   });
 
   // handlers triggered by inputView events