Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VSCode remote container setting files #138

Merged
merged 3 commits into from
Dec 30, 2019
Merged

Add VSCode remote container setting files #138

merged 3 commits into from
Dec 30, 2019

Conversation

smaeda-ks
Copy link
Collaborator

@smaeda-ks smaeda-ks commented Dec 30, 2019 •
edited
Loading

https://code.visualstudio.com/docs/remote/containers
What does this mean? so developers who installed VSCode + Docker can start twurl development instantly without setting up Ruby environment on their own machines.

Also, removing rubyforge_project options from .gemspec as it's deprecated.

@smaeda-ks smaeda-ks requested a review from a team December 30, 2019 18:22
@smaeda-ks smaeda-ks self-assigned this Dec 30, 2019
@coveralls
Copy link

coveralls commented Dec 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 88.565% when pulling 759c0df on smaeda-ks:smaeda-ks/docker-vscode into 4e8b5f9 on twitter:master.

andypiper
andypiper approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@andypiper andypiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ok to merge.

@smaeda-ks smaeda-ks merged commit 23a8374 into twitter:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypiper andypiper andypiper approved these changes

Assignees

@smaeda-ks smaeda-ks

Labels
Trivial
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smaeda-ks @coveralls @andypiper