This repository was archived by the owner on Jan 20, 2022. It is now read-only.
ensure at least one batch before merging #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
working on the tests here: tsdeng#1 |
| implicit def timeExtractor[T <: (Long, Any)] = TestUtil.simpleTimeExtractor[T] | ||
|
|
||
| implicit val arbitraryInputWithTimeStampAndBatcher: Arbitrary[(List[(Long, Int)], Batcher, TestStore[Int, Int])] = Arbitrary { | ||
| Arbitrary.arbitrary[List[Int]] |
There was a problem hiding this comment.
.zip or .join with Arbitrary.arbitrary[Map[Int, Int]]
There was a problem hiding this comment.
don't have two maps back to back, just do one.
Also, maybe for comprehension here.
…es the batcher to be at least 2ms
|
Hi, @johnynek |
| (timeMode: (Interval[Timestamp], Mode)) => | ||
| { | ||
| val (time: Interval[Timestamp], mode: Mode) = timeMode | ||
| val a: FlowToPipe[(Int, Int)] = Reader { (fdM: (FlowDef, Mode)) => TypedPipe.from[(Timestamp, (Int, Int))](Seq((Timestamp(10), (2, 3)))) } |
There was a problem hiding this comment.
why do you have the fake data here? Why not use PipeFactory[Nothing] which is a subclass of all PipeFactories? TypedPipe.empty gives you a TypedPipe[Nothing]
There was a problem hiding this comment.
It's because for merging, if it returns a TypedPipe[Nothing], then I need to define a semigroup of Nothing
johnynek
added a commit
that referenced
this pull request
Mar 24, 2015
…merging ensure at least one batch before merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry of
#612
the check of "at least one batch is covered by timespan" only applies to merging.