This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Make some classes public so we can make custom platforms #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,7 @@ private[summingbird] object SummingbirdRuntimeStats { | |||
| } | |||
| } | |||
|
|
|||
| private[summingbird] object JobCounters { | |||
There was a problem hiding this comment.
actually just below, you evaluate default more than once.
Might be better to do:
if (v == null) {
val vToPut = default
map.putIfAbsent(k, vToPut) match {
case null => vToPut
case vExists => vExists
}
}In this case it can still be evaluated when it is not needed (due to a concurrent put beating it in), but there are no loops and no two evals.
|
looks fine (except noticed a minor issue that might be nice to fix). |
ianoc
added a commit
that referenced
this pull request
Jan 23, 2015
Make some classes public so we can make custom platforms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.