This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Example of using DagOptimizer #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge master :) |
|
Sweeet!!!! I'll add some tests for the ConcurrentMemory platform before we review it. |
|
Added tests. Would love a review from @ianoc who is really familiar with planners. |
|
@egonina Can you take a look as well? You were looking at in-memory stats, so it would be relevant to this platform as well. |
| case object NullTarget extends PhysicalNode[Any] { | ||
| def push(item: Any)(implicit ec: ExecutionContext) = Future.successful(()) | ||
| } | ||
| case class FanOut[T](targets: Seq[PhysicalNode[T]]) extends PhysicalNode[T] { |
There was a problem hiding this comment.
what would this be used for? Could you add a comment?
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
* Add sumOption to Short,Int,Long,Float,Double * bump mima to 0.1.9 * address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See how much easier it is to implement a planner here.
We use the optimizer to first apply optimizations and remove unneeded nodes, then we only have to handle 5 cases.
This should not be merged before the dag optimizer pull request is.