Add an option to configure ComposePreviewPublic to flag all previews #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `ComposePreviewPublic` will only flag public previews if they use a `@PreviewParameter`, because we know for sure that they are only going to be used for previews. This will continue to be the default behavior, but if people want to flag ALL public previews, they can use `previewPublicOnlyIfParams` to do that now. Closes #95.
mrmans0n
requested review from
chrisbanes,
flubarb,
sierraobryan,
taysand,
wsf20 and
YoaliSB
mrmans0n
commented
Oct 11, 2022
| visitClass(klass, autoCorrect, emitter) | ||
| } | ||
|
|
||
| override fun visitKtElement(element: KtElement) { | ||
| super.visitKtElement(element) | ||
| element.attach(config) |
There was a problem hiding this comment.
I found an issue in which visitKtElement was being called while visitFile wasn't 🤷 so I am attaching the config in all entrypoints, and made attach to be fine with that.
| @@ -37,7 +37,7 @@ internal class KtlintComposeKtConfig( | |||
| getValueAsOrPut(key) { getList(key, default.toList()).toSet() } ?: default | |||
|
|
|||
| override fun getBoolean(key: String, default: Boolean): Boolean = | |||
| getValueAsOrPut(key) { properties[ktlintKey(key)]?.getValueAs<String>()?.toBooleanStrictOrNull() } ?: default | |||
| getValueAsOrPut(key) { properties[ktlintKey(key)]?.getValueAs<Boolean>() } ?: default | |||
There was a problem hiding this comment.
This stores a boolean for realsies now
| @@ -83,4 +86,15 @@ class KtlintComposeKtConfigTest { | |||
|
|
|||
| private val String.prop: Property | |||
| get() = Property.builder().value(this).build() | |||
|
|
|||
| private val Boolean.prop: Property | |||
There was a problem hiding this comment.
massive yuck but works
chrisbanes
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
ComposePreviewPublicwill only flag public previews if they use a@PreviewParameter, because we know for sure that they are only going to be used for previews. This will continue to be the default behavior, but if people want to flag ALL public previews, they can usepreviewPublicOnlyIfParamsto do that now.Closes #95.