Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 289 #293

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Fix 289 #293

merged 2 commits into from
Dec 3, 2023

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Nov 28, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

#289

Description of Changes:

  • Changed .Run(...) to .RunE(...) in cmd/token.go
  • Added missing return on cmd/configure.go

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo linked an issue Nov 28, 2023 that may be closed by this pull request
[Bug] Twitch token subcommand fails with segmentation fault #289
Closed
@Xemdo Xemdo merged commit 80a65fd into main Dec 3, 2023
@Xemdo Xemdo deleted the fix-289 branch December 3, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lleadbet lleadbet lleadbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Twitch token subcommand fails with segmentation fault
2 participants
@Xemdo @lleadbet