Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow perma ban testing for channel.ban #257

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Allow perma ban testing for channel.ban #257

merged 1 commit into from
Aug 9, 2023

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Jul 24, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Fixes #195

Description of Changes:

  • twitch event trigger channel.ban now defaults to permabans
  • Added --ban-start flag to specify the banned_at field
  • Added --ban-end flag to specify the ends_at field and inherently the is_permanent field
  • Moved ban/unban events to their own files

--ban-end flag takes custom values, single numeric values for seconds (e.g. 600), or shorthand times (e.g. 10d4h12m55s)

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

…wing users to specify ban start and ban end fields (and inheritely, is_permanent)
Copy link
Contributor

@BarryCarlyon BarryCarlyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEEMS GOOD

Copy link
Contributor

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and works as expected.

@Xemdo Xemdo merged commit 2f6df3b into main Aug 9, 2023
@Xemdo Xemdo deleted the fix-195 branch August 9, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock event for /ban only tests timeouts
3 participants