Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with retrigger events when events have multiple versions #244

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Jun 28, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

There was an issue with twitch retrigger where channel.follow didn't work due to its multiple versions. The wrong object type was being used when unmarshaling the JSON, which didn't throw an error but didn't fill in any data. This wasn't noticed because the only time that object is used for refiring the event is when grabbing the subscription version, but for subscriptions with only one version available the subscription version can be empty and it'll default to the only one available.

Description of Changes:

  • Fixed bug where twitch retrigger doesn't work for channel.follow due to having multiple versions

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo merged commit 3d4f21a into main Jun 29, 2023
@Xemdo Xemdo deleted the retrigger-follow-fix branch June 29, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant