Green up the tests #396
Green up the tests #396
Conversation
It looks like OpenSSL has type hints now.
| @@ -207,14 +207,16 @@ def test_content_application_json_default_encoding(self): | |||
|
|
|||
| def test_text_content_unicode_headers(self): | |||
| """ | |||
| Header parsing is robust against unicode header names and values. | |||
| Parsing of the Content-Type header is robust in the face of | |||
| Unicode gunk in the header value, which is ignored. | |||
There was a problem hiding this comment.
I am not familiar with the code from here... so feel free to ignore this comment.
I don't understand the docstring for this test...
I mean, I understand what it wanted to do, but I don't see how this is put into practice in the test code itself.
| Unicode gunk in the header value, which is ignored. | |
| Unicode junk in the header value, which is ignored. |
There was a problem hiding this comment.
It can also be a unicode hunk (in this case meant as a byte sequence \xe1\x9b\x83 - which is the byte representation of the utf-8 code point of the given character).
All those bytes are invalid for http header value.
There was a problem hiding this comment.
Exactly — "ᛃ" is the "gunk". This is basically a smoke test that there isn't a .decode('ascii') in the header processing that might blow up.
|
Thanks for taking a look @adiroiban and @pmisik! |
Remove an invalid HTTP header name from a test case. The header name itself appears to be dead code — the code under test only parses the Content-Type header.
Fixes #395.