Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.13 support #392

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add Python 3.13 support #392

merged 1 commit into from
Sep 17, 2024

Conversation

pmisik
Copy link
Contributor

@pmisik pmisik commented Sep 14, 2024

PR #391

@twm
Copy link
Contributor

twm commented Sep 15, 2024

Hmm, it looks like we need to move to Ubuntu 22.04 to get Python 3.13. Could you submit a separate PR with that change to the GHA worflows?

@pmisik pmisik mentioned this pull request Sep 15, 2024
Closed
@pmisik pmisik changed the title [WIP] Add Python 3.13 support Add Python 3.13 support Sep 15, 2024
pmisik
pmisik commented Sep 16, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
twm
twm reviewed Sep 16, 2024
View reviewed changes
changelog.d/391.feature.rst Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@twm
Copy link
Contributor

twm commented Sep 16, 2024

BTW the package metadata should be updated as well.

@pmisik pmisik marked this pull request as ready for review September 16, 2024 20:51
twm
twm approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much!

@twm twm merged commit bbf9114 into twisted:trunk Sep 17, 2024
17 checks passed
@twm twm mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twm twm twm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmisik @twm