#408 Fix Read the docs build. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #409 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 22 22
Lines 1400 1400
Branches 130 124 -6
=======================================
Hits 1370 1370
Misses 15 15
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hynek
reviewed
Aug 30, 2022
exarkun
reviewed
Aug 30, 2022
docs/conf.py
Outdated
| project = "Towncrier" | ||
| copyright = "2017, Amber Brown" | ||
| copyright = "{}, Towncrier contibutors. Ver {}. Built on {}".format( |
hynek
approved these changes
Aug 31, 2022
|
Thanks for your reviews. I think we are in good shape. Happy to see the dev docs available as part of the Read The Docs build. |
|
This is a good moment to switch the default to "stable" instead of "latest"? |
|
Done. Thanks for the headup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build on RTD for trunk fails due to missing version in docs/conf.py
Changes
The version was previously removed as it was a static version.
It was not replaced with the real version.
The copyright was also updated to include the version and build time.
The RTD was updated not to generate PDF and EPUB.