-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 21.3.0 #332
Release 21.3.0 #332
Changes from 2 commits
05eea3f
4143e0f
6eab894
3237ebd
3bf4479
bd963c3
eab3461
7a080f6
0182019
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Why did I think that misc was ignored... bah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
towncrier/pyproject.toml
Lines 30 to 33 in 4143e0f
Is this supposed to do what's above? Or totally not include it in the output? Guess I'll dive into the tests to try to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that misc hasn't been used since 17.4.0 but it does look quite intentionally formatted. I guess this is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how towncrier works by default... and how it's used in Twisted (without the extra links).
It only hides the "content" and not the note number itself :p
I am using a custom template in which
showcontent
is completely ignored.Maybe besides
showcontent
the default template can have a newignore
that can be used to now show that type at all in the release notes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Can we manually remove the misc section?