-
Notifications
You must be signed in to change notification settings - Fork 122
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add --keep option to allow to generate newsfile, but keep newsfragmen… (
#453) * Add --keep option to allow to generate newsfile, but keep newsfragments - closes #129 * Apply suggestions from code review Co-authored-by: Adi Roiban <adiroiban@gmail.com> * Additional post-PR enhancements * Update build --keep comment to be more relevant Co-authored-by: Adi Roiban <adiroiban@gmail.com> * More compact remove_files and use with_isolated_runner for new tests * Refactored _git.remove_files Code making decision to remove prompt or keep news fragments is being kept in new intermediate function _remover.remove_news_fragment_files * Update src/towncrier/newsfragments/129.feature Co-authored-by: Hynek Schlawack <hs@ox.cx> * Make a decision and return it instead of calling _git.remove underneath * Move should_remove_fragment_files into build module Co-authored-by: Adi Roiban <adiroiban@gmail.com> Co-authored-by: Hynek Schlawack <hs@ox.cx>
- Loading branch information
1 parent
9554985
commit 24f65a0
Showing
5 changed files
with
130 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Added ``--keep`` option to the ``build`` command that allows to generate a newsfile, but keeps the newsfragments in place. | ||
This option can not be used together with ``--yes``. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters