Fix implicitly null parameter types in templates #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will trigger deprecation warnings in PHP 8.4.
|
@sagikazarmark could we please get a release with this change? No massive rush, but it would be great to have before PHP 8.4 is released in about two months. Thanks! |
|
Sure! Tagged 0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix implicitly null parameter types in templates.
What this PR does / why we need it
In PHP 8.4, implicitly nullable parameter types will be deprecated. Read the RFC for more details. This change will prevent a deprecation warning once PHP 8.4 is released. It has no effect on earlier PHP versions.
Instances of this were already fixed via php-cs-fixer in non-templated code, so this is also more consistent within the code base.
Does this PR introduce a user-facing change?